don't fail on unicode js newlines (\u2028, \u2029) #1655
Merged
+26
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSON isn't a proper subset of JavaScript, and JSON.stringify is horribly broken by default. So when those two characters were used, Jade was creating a template with syntax error (with valid JSON, but invalid JS).
ForbesLindesay
added a commit
that referenced
this pull request
Sep 5, 2014
don't fail on unicode js newlines (\u2028, \u2029)
|
Thanks, this is awesome work. |
|
I've invited you to our maintainers team (I'm attempting to broaden the number of people who are able to help maintain the jade project). Please continue to submit patches via pull requests, but feel free to merge other people's pull requests if they are getting ignored and close issues as you see fit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you ask me what is the most stupid standard in JavaScript world, I'd say JSON is second to none.
No comments allowed, no trailing commas (which constantly screws up git diffs), no good Date representation,
\vis confusingly missing... did I forget anything?Oh right, and JSON.stringify is broken in a way that its output can't be embedded in the JavaScript source code as is.
Bug report:
#1648
Details:
https://code.google.com/p/v8/issues/detail?id=1907
Same fix as in:
expressjs/express#1132